Repository navigation
chore(host-service): bump version to 0.7.0 + raise min version - #4046
Conversation
Bumps both HOST_SERVICE_VERSION and MIN_HOST_SERVICE_VERSION from 0.6.0 to 0.7.0. PR1 (#3893) added the canonical `workspaces.create` flow and `settings.hostAgentConfigs` router; 0.6.x host-services don't expose either, so adopting one in place would break v2 new-project creation and the agent-config settings UI. The coordinator's tryAdopt will SIGTERM any pre-0.7.0 service on first launch and respawn with the new bundle.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe host-service compatibility version is bumped from ChangesHost-Service Version Synchronization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 6/8 reviews remaining, refill in 11 minutes and 24 seconds.Comment |
Greptile SummaryThis PR bumps Confidence Score: 5/5Safe to merge — version constants are consistent across both files and the respawn guard logic is unchanged. The change is two constant string updates with matching values and updated inline docs. The existing semver guard and SIGTERM-on-adopt path are untouched. The only finding is a missing 0.6.0 entry in the changelog comment, which is P2. No files require special attention.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/main/lib/host-service-coordinator.ts | Bumps MIN_HOST_SERVICE_VERSION from "0.6.0" to "0.7.0" with an updated JSDoc entry; SIGTERM-on-adopt and semver guard logic untouched. Minor: 0.6.0 changelog entry is absent. |
| packages/host-service/src/trpc/router/host/host.ts | Bumps HOST_SERVICE_VERSION constant from "0.6.0" to "0.7.0" with a matching comment; consistent with MIN_HOST_SERVICE_VERSION in the coordinator. |
Sequence Diagram
sequenceDiagram
participant Desktop as Desktop Coordinator
participant Manifest as Manifest File
participant OldHS as Old Host-Service (0.6.x)
participant NewHS as New Host-Service (0.7.0)
Desktop->>Manifest: readManifest(orgId)
Manifest-->>Desktop: manifest (pid, endpoint)
Desktop->>OldHS: GET /trpc/host.info
OldHS-->>Desktop: version = "0.6.0"
Desktop->>Desktop: semver.satisfies("0.6.0", ">=0.7.0") → false
Desktop->>OldHS: SIGTERM
Desktop->>Manifest: removeManifest(orgId)
Desktop->>NewHS: spawn(orgId, config)
NewHS-->>Desktop: healthy on port N
Desktop-->>Desktop: Connection { port, secret }
Comments Outside Diff (1)
-
apps/desktop/src/main/lib/host-service-coordinator.ts, line 44-59 (link)Missing 0.6.0 changelog entry in version history
The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR chore(host-service): bump version to 0.6.0 + raise min version #4006, which set the previous
MIN_HOST_SERVICE_VERSION = "0.6.0") has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established.Prompt To Fix With AI
This is a comment left during a code review. Path: apps/desktop/src/main/lib/host-service-coordinator.ts Line: 44-59 Comment: **Missing 0.6.0 changelog entry in version history** The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR #4006, which set the previous `MIN_HOST_SERVICE_VERSION = "0.6.0"`) has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/desktop/src/main/lib/host-service-coordinator.ts:44-59
**Missing 0.6.0 changelog entry in version history**
The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR #4006, which set the previous `MIN_HOST_SERVICE_VERSION = "0.6.0"`) has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established.
```suggestion
* 0.5.0 — pty-daemon supervision migrated into host-service. New
* `terminal.daemon` tRPC namespace; older 0.4.x host-services don't
* expose it. Adopting one in place would leave the new desktop
* talking to old code: Settings → Manage daemon would silently
* fail, and the v2 PTY survival promise is broken. Bumping the
* floor forces the coordinator's `tryAdopt` (host-service-coordinator
* line ~308) to SIGTERM old host-services on first launch and
* respawn with the new bundle. One-time terminal-session loss for
* users on upgrade — accepted per release-notes guidance.
*
* 0.6.0 — (PR #4006) <brief description of what changed at 0.6.0>
*
* 0.7.0 — canonical `workspaces.create` flow + `settings.hostAgentConfigs`
```
Reviews (1): Last reviewed commit: "chore(host-service): bump version to 0.7..." | Re-trigger Greptile
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…evAI#4046) Bumps both HOST_SERVICE_VERSION and MIN_HOST_SERVICE_VERSION from 0.6.0 to 0.7.0. PR1 (ParadevAI#3893) added the canonical `workspaces.create` flow and `settings.hostAgentConfigs` router; 0.6.x host-services don't expose either, so adopting one in place would break v2 new-project creation and the agent-config settings UI. The coordinator's tryAdopt will SIGTERM any pre-0.7.0 service on first launch and respawn with the new bundle.
…low-up ParadevAI#4074 exhaustive worktree search in v2 branch picker: - adopt.ts / search-branches.ts / branch-search.ts: whole-file upstream overwrite. Fork's <repoPath>/.worktrees/<branch>-scoped variant (FORK NOTE in branch-search.ts) is dropped in favour of upstream's exhaustive 'all git worktrees including foreign ones' strategy. This matches ParadevAI#4226's adopt-foreign-worktree UX direction. ParadevAI#4160 listBranches single git spawn perf (skipped, HEAD-preferred): - packages/host-service/src/trpc/router/git/git.ts: keep fork's rich listBranches (sortOrder/pinDefault/buildBranch per-branch upstream/ahead-behind/last-commit). Upstream's 4xN -> 1 spawn simplification drops those fields the fork's BaseBranchSelector consumes; perf win not worth the rich UI regression. Revisit if BaseBranchSelector is unified with upstream's BaseBranchSelector in a future cycle. ParadevAI#4218 respawn host-service on Electron auto-update: - packages/host-service/package.json: merge fork's ./settings export and upstream's ./package.json export (both needed). - packages/host-service/src/trpc/router/host/host.ts: whole-file upstream overwrite. HOST_SERVICE_VERSION switches from fork's hard-coded '0.7.0' to dynamic hostServicePackageJson.version (currently 0.8.1). Bumps via apps/desktop/electron-builder.ts respawn flow are now automatic. ParadevAI#4231 restore terminal modes on reattach via headless xterm: - packages/host-service/src/terminal/terminal.ts: createModeTracker call sites referenced un-declared 'cols, rows' inside session-create closure; fix to hard-code (120, 32) which matches the daemon.open() call above. Real cols/rows arrive via subsequent resize() calls; modeTracker.resize handles the update path. Files clean cherry-picked: ParadevAI#4046 host-service bump 0.7.0, plus adopt-foreign-worktree wiring.
Summary
HOST_SERVICE_VERSIONandMIN_HOST_SERVICE_VERSIONfrom 0.6.0 → 0.7.0.workspaces.createflow andsettings.hostAgentConfigsrouter. 0.6.x host-services don't expose either, so adopting one in place would break v2 new-project creation and the agent-config settings UI.tryAdoptto SIGTERM any pre-0.7.0 service on first launch and respawn with the new bundle. Same one-time disruption pattern as the prior 0.5 → 0.6 bump (chore(host-service): bump version to 0.6.0 + raise min version #4006).Test plan
workspaces.createandsettings.hostAgentConfigswork post-respawn.Summary by cubic
Bumps the host service to 0.7.0 and raises the minimum required version to 0.7.0. This enforces support for
workspaces.createandsettings.hostAgentConfigsand prevents broken v2 new-project creation and agent-config settings.Written for commit fb3a36b. Summary will update on new commits.
Summary by CodeRabbit