Skip to content

chore(host-service): bump version to 0.7.0 + raise min version - #4046

Merged
Kitenite merged 1 commit into
mainfrom
update-host-service-versi-2
May 4, 2026
Merged

Kitenite merged 1 commit into
mainfrom
update-host-service-versi-2

Conversation

@Kitenite

@Kitenite Kitenite commented May 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Test plan

  • Launch desktop with an adopted 0.6.x host-service; confirm it gets killed + respawned at 0.7.0.
  • Verify v2 workspaces.create and settings.hostAgentConfigs work post-respawn.
  • Fresh install (no prior service): host-service starts at 0.7.0, no respawn loop.

Summary by cubic

Bumps the host service to 0.7.0 and raises the minimum required version to 0.7.0. This enforces support for workspaces.create and settings.hostAgentConfigs and prevents broken v2 new-project creation and agent-config settings.

  • Migration
    • On first launch with a 0.6.x service, the coordinator sends SIGTERM and respawns with the 0.7.0 bundle (one-time).
    • Fresh installs start at 0.7.0 with no respawn loop.

Written for commit fb3a36b. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated the minimum required host-service version to 0.7.0. Services running versions older than 0.7.0 will now be marked as incompatible and automatically removed from the system to maintain platform stability and compatibility.

Bumps both HOST_SERVICE_VERSION and MIN_HOST_SERVICE_VERSION from
0.6.0 to 0.7.0. PR1 (#3893) added the canonical `workspaces.create`
flow and `settings.hostAgentConfigs` router; 0.6.x host-services
don't expose either, so adopting one in place would break v2
new-project creation and the agent-config settings UI. The
coordinator's tryAdopt will SIGTERM any pre-0.7.0 service on
first launch and respawn with the new bundle.
@coderabbitai

coderabbitai Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ab4e22f2-ecbd-4eb3-81ea-335f3f1fffb5

📥 Commits

Reviewing files that changed from the base of the PR and between 40494b8 and fb3a36b.

📒 Files selected for processing (2)
  • apps/desktop/src/main/lib/host-service-coordinator.ts
  • packages/host-service/src/trpc/router/host/host.ts

📝 Walkthrough

Walkthrough

The host-service compatibility version is bumped from 0.6.0 to 0.7.0 across two coordination points: the desktop app's minimum supported version check and the host-service's self-reported version constant. The change affects version validation during service adoption but does not alter spawning or API mechanisms.

Changes

Host-Service Version Synchronization

Layer / File(s) Summary
Version Constants
apps/desktop/src/main/lib/host-service-coordinator.ts, packages/host-service/src/trpc/router/host/host.ts
MIN_HOST_SERVICE_VERSION and HOST_SERVICE_VERSION both updated from "0.6.0" to "0.7.0".
Compatibility Notes
packages/host-service/src/trpc/router/host/host.ts
Compatibility documentation extended to document 0.7.0 router changes for workspaces.create and settings.hostAgentConfigs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A hop and a bump, versions align,
From point-six to point-seven so fine,
No broken hearts here, just compatible ears,
The rabbit approves—let adoption run clear! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: bumping the host-service version to 0.7.0 and raising the minimum required version, which aligns with the core modifications in both files.
Description check ✅ Passed The PR description comprehensively covers all required template sections with clear explanations, test plans, and context about the version bump rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-host-service-versi-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 6/8 reviews remaining, refill in 11 minutes and 24 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps HOST_SERVICE_VERSION and MIN_HOST_SERVICE_VERSION from "0.6.0" to "0.7.0" across the host-service package and desktop coordinator, following the same forced-respawn pattern used for the prior 0.5→0.6 transition. The coordinator's tryAdopt will SIGTERM any pre-0.7.0 service on first launch and respawn with the new bundle, ensuring the new workspaces.create and settings.hostAgentConfigs routes are always available.

Confidence Score: 5/5

Safe to merge — version constants are consistent across both files and the respawn guard logic is unchanged.

The change is two constant string updates with matching values and updated inline docs. The existing semver guard and SIGTERM-on-adopt path are untouched. The only finding is a missing 0.6.0 entry in the changelog comment, which is P2.

No files require special attention.

Important Files Changed

Filename Overview
apps/desktop/src/main/lib/host-service-coordinator.ts Bumps MIN_HOST_SERVICE_VERSION from "0.6.0" to "0.7.0" with an updated JSDoc entry; SIGTERM-on-adopt and semver guard logic untouched. Minor: 0.6.0 changelog entry is absent.
packages/host-service/src/trpc/router/host/host.ts Bumps HOST_SERVICE_VERSION constant from "0.6.0" to "0.7.0" with a matching comment; consistent with MIN_HOST_SERVICE_VERSION in the coordinator.

Sequence Diagram

sequenceDiagram
    participant Desktop as Desktop Coordinator
    participant Manifest as Manifest File
    participant OldHS as Old Host-Service (0.6.x)
    participant NewHS as New Host-Service (0.7.0)

    Desktop->>Manifest: readManifest(orgId)
    Manifest-->>Desktop: manifest (pid, endpoint)
    Desktop->>OldHS: GET /trpc/host.info
    OldHS-->>Desktop: version = "0.6.0"
    Desktop->>Desktop: semver.satisfies("0.6.0", ">=0.7.0") → false
    Desktop->>OldHS: SIGTERM
    Desktop->>Manifest: removeManifest(orgId)
    Desktop->>NewHS: spawn(orgId, config)
    NewHS-->>Desktop: healthy on port N
    Desktop-->>Desktop: Connection { port, secret }
Loading

Comments Outside Diff (1)

  1. apps/desktop/src/main/lib/host-service-coordinator.ts, line 44-59 (link)

    P2 Missing 0.6.0 changelog entry in version history

    The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR chore(host-service): bump version to 0.6.0 + raise min version #4006, which set the previous MIN_HOST_SERVICE_VERSION = "0.6.0") has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/desktop/src/main/lib/host-service-coordinator.ts
    Line: 44-59
    
    Comment:
    **Missing 0.6.0 changelog entry in version history**
    
    The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR #4006, which set the previous `MIN_HOST_SERVICE_VERSION = "0.6.0"`) has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/desktop/src/main/lib/host-service-coordinator.ts:44-59
**Missing 0.6.0 changelog entry in version history**

The in-file version history jumps directly from 0.5.0 to 0.7.0. The 0.6.0 milestone (PR #4006, which set the previous `MIN_HOST_SERVICE_VERSION = "0.6.0"`) has no corresponding entry, making the changelog incomplete and potentially confusing for future authors tracing why a given floor was established.

```suggestion
 * 0.5.0 — pty-daemon supervision migrated into host-service. New
 * `terminal.daemon` tRPC namespace; older 0.4.x host-services don't
 * expose it. Adopting one in place would leave the new desktop
 * talking to old code: Settings → Manage daemon would silently
 * fail, and the v2 PTY survival promise is broken. Bumping the
 * floor forces the coordinator's `tryAdopt` (host-service-coordinator
 * line ~308) to SIGTERM old host-services on first launch and
 * respawn with the new bundle. One-time terminal-session loss for
 * users on upgrade — accepted per release-notes guidance.
 *
 * 0.6.0 — (PR #4006) <brief description of what changed at 0.6.0>
 *
 * 0.7.0 — canonical `workspaces.create` flow + `settings.hostAgentConfigs`
```

Reviews (1): Last reviewed commit: "chore(host-service): bump version to 0.7..." | Re-trigger Greptile

@github-actions

github-actions Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@Kitenite
Kitenite merged commit 87ec53b into main May 4, 2026
15 checks passed
@Kitenite
Kitenite deleted the update-host-service-versi-2 branch May 4, 2026 16:41
MocA-Love pushed a commit to MocA-Love/superset that referenced this pull request May 21, 2026
…evAI#4046)

Bumps both HOST_SERVICE_VERSION and MIN_HOST_SERVICE_VERSION from
0.6.0 to 0.7.0. PR1 (ParadevAI#3893) added the canonical `workspaces.create`
flow and `settings.hostAgentConfigs` router; 0.6.x host-services
don't expose either, so adopting one in place would break v2
new-project creation and the agent-config settings UI. The
coordinator's tryAdopt will SIGTERM any pre-0.7.0 service on
first launch and respawn with the new bundle.
MocA-Love added a commit to MocA-Love/superset that referenced this pull request May 21, 2026
…low-up

ParadevAI#4074 exhaustive worktree search in v2 branch picker:
- adopt.ts / search-branches.ts / branch-search.ts: whole-file upstream
  overwrite. Fork's <repoPath>/.worktrees/<branch>-scoped variant
  (FORK NOTE in branch-search.ts) is dropped in favour of upstream's
  exhaustive 'all git worktrees including foreign ones' strategy. This
  matches ParadevAI#4226's adopt-foreign-worktree UX direction.

ParadevAI#4160 listBranches single git spawn perf (skipped, HEAD-preferred):
- packages/host-service/src/trpc/router/git/git.ts: keep fork's rich
  listBranches (sortOrder/pinDefault/buildBranch per-branch
  upstream/ahead-behind/last-commit). Upstream's 4xN -> 1 spawn
  simplification drops those fields the fork's BaseBranchSelector
  consumes; perf win not worth the rich UI regression. Revisit if
  BaseBranchSelector is unified with upstream's BaseBranchSelector
  in a future cycle.

ParadevAI#4218 respawn host-service on Electron auto-update:
- packages/host-service/package.json: merge fork's ./settings export
  and upstream's ./package.json export (both needed).
- packages/host-service/src/trpc/router/host/host.ts: whole-file upstream
  overwrite. HOST_SERVICE_VERSION switches from fork's hard-coded
  '0.7.0' to dynamic hostServicePackageJson.version (currently 0.8.1).
  Bumps via apps/desktop/electron-builder.ts respawn flow are now
  automatic.

ParadevAI#4231 restore terminal modes on reattach via headless xterm:
- packages/host-service/src/terminal/terminal.ts: createModeTracker
  call sites referenced un-declared 'cols, rows' inside session-create
  closure; fix to hard-code (120, 32) which matches the daemon.open()
  call above. Real cols/rows arrive via subsequent resize() calls;
  modeTracker.resize handles the update path.

Files clean cherry-picked: ParadevAI#4046 host-service bump 0.7.0, plus
adopt-foreign-worktree wiring.

This branch was previously deployed

1 inactive deployment
preview — fb3a36b1 Deployed May 4, 2026 by Kitenite via Deploy Admin #4855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant